Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastText restores settings at startup #39

Closed
andremeireles opened this issue Jan 14, 2023 · 2 comments
Closed

FastText restores settings at startup #39

andremeireles opened this issue Jan 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@andremeireles
Copy link

User report

Description: After to install fastText language model, this plugin saves the plugins list setup (which one is on or off), including the chosen theme and restores everything at obsidian startup.
So if you activate or deactivate plugins after activated this one, the changes will be "forgotten".
It's necessary activate obsidian-translate last if you want to avoid that.

Reproducible Steps

1- Choose bergamot as the service
2- Install bergamot models
3- Install fastText

After that, whathever modifications will be discarded at restart.

Temp Fix

Uninstall fastText or activate obsidian-translate last.


Debugger data (do not alter)

plugin_version: "1.4.3"
platform: "Desktop"
framework_version: "0.15.6"
obsidian_version: "1.1.9"
selected_service: "bergamot"

@Fevol Fevol added the bug Something isn't working label Jan 14, 2023
@Fevol Fevol self-assigned this Jan 14, 2023
@Fevol
Copy link
Owner

Fevol commented Jan 14, 2023

Many, many thanks for your detailed report! I had encountered this bug before, but I couldn't reproduce it. Your steps helped immensely with figuring out where the problem was located.

To explain the issue: when FastText is loaded during the initial app start-up (which happens when Bergamot & FastText are installed, or the glossary feature is enabled), there was an instruction that got executed, which made Obsidian think that all plugins were already loaded, even when we're still in the middle of loading them all. Thats' why it wasn't an issue when the plugin was enabled last.

I sincerely apologize for the trouble that this caused, I really should've caught this issue sooner. I'll try to get a new release out that fixes this issue ASAP.


Edit: Fix is now available with release 1.4.4, many thanks again for reporting this!

@andremeireles
Copy link
Author

It took me a while to reproduce the bug with other vaults, but when I did I was very happy because I was sure that such a good product would not be buggy for such a long time.
Thank you for being available so quickly and fixing the bug.
kudos for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants