Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph breaks not preserved in lingva Eng-> japanese #53

Closed
ksdavidc opened this issue Jul 15, 2023 · 6 comments
Closed

Paragraph breaks not preserved in lingva Eng-> japanese #53

ksdavidc opened this issue Jul 15, 2023 · 6 comments
Assignees
Labels
bug Something isn't working is/ready to ship Will be shipped in the next update

Comments

@ksdavidc
Copy link

Hi (long time no see). I haven't been using the plugin much lately for various reasons, but started up recently. One thing hanging me up is a snag with the lingva translator. It may not be with the plugin at all, but I find that in translating english to japanese, french and portuguese (the only languages I tested), paragraph breaks are not preserved, which was slowing me down. I don't konw if it something fixable on your end, but I thought I'd let you know. Aside from that, hope you are doing well...

@Fevol
Copy link
Owner

Fevol commented Aug 1, 2023

Hey, I'm really sorry for the wait! I've tried fixing this a couple weeks before, but the lingva services seemed to be down. Apparently all .ml domains were taken offline, only 4 of the services still work.

Either way, I found the issue, and everything should work now, I forgot to properly encode the endline/paragraph breaks...

I'll be pushing this soon, thank you for reporting the issue! Sorry again for being so late with this, I've been getting distracted with the other plugin I've been working on 😅

@Fevol Fevol self-assigned this Aug 1, 2023
@Fevol Fevol added bug Something isn't working is/ready to ship Will be shipped in the next update labels Aug 1, 2023
@ksdavidc
Copy link
Author

ksdavidc commented Aug 1, 2023

Hi, that's great. No worries about the time. I am a slow burner myself, and anyway you have my implicit trust. Are you talking about criticmarkup? Nice idea! (though I wouldn't have call to use it.)

@Fevol
Copy link
Owner

Fevol commented Aug 1, 2023

Yep, the CriticMarkup plugin! Basically, I'm trying to squeeze Google Docs/Word's suggestion mode and comment system into Obsidian. It will be helpful for tracking changes, collaborating with people or leaving notes for yourself using pure markdown. There's still a lot of work left that needs to be done, but I'm getting closer and closer to a working product.

@Fevol
Copy link
Owner

Fevol commented Aug 4, 2023

Closing this issue as the fix is shipped with update 1.4.6, thanks again for the issue report!

@Fevol Fevol closed this as completed Aug 4, 2023
@ksdavidc
Copy link
Author

ksdavidc commented Aug 8, 2023

Great. It works.

FYI when I updated the plugin, reloading Obsidian didn't complete and I got one of those reboot or turn off community plugins messages. Eventually I had to reinstall the plugin from scratch and redo my settings, but it is working now beautifully, saving me a lot of time. Thanks!

@Fevol
Copy link
Owner

Fevol commented Aug 9, 2023

Agh, that should never happen. Something may have gone wrong with the plugin's data when updating, though without error logs, it's hard to say. I'm sorry for that major inconvenience! Sometimes it feels like the plugin is barely held together by spit and baling wire. I'll be on the look-out for cases where this may happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working is/ready to ship Will be shipped in the next update
Projects
None yet
Development

No branches or pull requests

2 participants