Collections #56
Merged
Collections #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved functional table/array methods into a new class - Support multiple types for sum, difference, product, and quotient
- Fixed userdata return values instead of Vectors - Added the functional methods map, each, flatMap, and filter
TheBunnyMan123
previously requested changes
May 25, 2024
PoolloverNathan
approved these changes
May 26, 2024
|
misclick sorry |
|
I'll do the wiki part soon™ |
PoolloverNathan
requested changes
May 26, 2024
PoolloverNathan
previously requested changes
May 26, 2024
common/src/main/java/com/thekillerbunny/goofyplugin/lua/CollectionAPI.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/thekillerbunny/goofyplugin/mixin/FiguraAPIManagerMixin.java
Show resolved
Hide resolved
|
alright we've got the shit now we need to get it in, running tests now |
|
tests passed, let's merge |
PoolloverNathan
previously approved these changes
May 26, 2024
PoolloverNathan
dismissed
their stale review
letting Bunny make sure this actually looks good
PoolloverNathan
requested review from
TheBunnyMan123 and
FokoHetman
and removed request for
TheBunnyMan123
|
|
FokoHetman
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Collections API which is designed to offload bulk table operations to Java as an optimization.
I've tested all methods for functionality, but some might not handle certain cases. This PR is to allow maintainers to give feedback on the code.
Credit to @TheBunnyMan123 for the initial implementation of the API.