Raycast vector arguments are now at the beginning of the function #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops. I committed to the wrong branch. Oh well. There is now a new raycast function that raycasts user provided AABBs using vanilla functions |
|
because the raycast api hasn't actually made it's way into a stable release, this is okay, it looks good to me. |
superpowers04
pushed a commit
to superpowers04/Extura
that referenced
this pull request
Feb 4, 2024
Raycast vector arguments are now at the beginning of the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the Raycast functions so that the vectors are at the beginning of the function signature. This is what I wanted to do originally, but didnt have the tech to take into account arguments after the vectors.
Additionally, this adds a generic vector parsing util function that can handle everything that all the current vector parsing functions can do, but in a single function. The pre-existing hardcoded functions will definitely be faster than this new function, but this is the only function that allows for parsing vectors with arguments after the vectors, so use it whenever another raycast function situation happens again.