Cancel sounds #170
Merged
Cancel sounds #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do not feel obligated to include this for 0.1.3. It can wait |
|
looks good to me |
superpowers04
pushed a commit
to superpowers04/Extura
that referenced
this pull request
Feb 4, 2024
Cancel sounds
This was referenced Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allows preventing any sound from playing when a user returns
truein theON_PLAY_SOUNDevent.Any player can block any sound, so this is only enabled by default for HIGH trust and above.
users can use the sound's position relative to their player's position to target sounds their player generates.
I had 4p5 bugtest this time, so there should be no issues
This completes the Allow canceling any vanilla sounds using the ON_PLAY_SOUND event suggestion from discord