Attempt 2 (to) fix issue #50 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnlikePaladin
requested changes
Aug 21, 2023
common/src/main/java/org/figuramc/figura/mixin/render/renderers/SkullBlockRendererMixin.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/figuramc/figura/mixin/render/renderers/SkullBlockRendererMixin.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/figuramc/figura/mixin/render/renderers/SkullBlockRendererMixin.java
Show resolved
Hide resolved
…s/SkullBlockRendererMixin.java Co-authored-by: UnlikePaladin <36827970+UnlikePaladin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time i got 3 players who experienced the issue constantly because i myself couldn't recreate the issue.
The issue is a race condition with avatar being set to null in a render at line 56 while at the same time being called for permissions in line 92.
(The slower the computer the better for recreation)
i do not know why this happens in the chunkbuilder. but i believe it is related to a bigger issue in the chunk thread builder renderer.
removing the nullset fixed all 3 players.
This time the code is tested and found to be working. closes #50