Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node to v14 #74

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Upgrade Node to v14 #74

merged 1 commit into from
Sep 28, 2020

Conversation

andygout
Copy link
Contributor

Please run appropriate tests and checks to ensure that the app is compatible with this Node version. https://node.green is a useful reference.

This PR was created using a nori script 🍙

Nori is a command-line application for managing changes across multiple (usually Github) repositories.

@andygout andygout requested a review from a team as a code owner September 23, 2020 07:31
Changes:

- `package.json` field `engines.node` - added, did not previously exist
- `.nvmrc` - created
- `.circleci/config.yml` Docker image for `container_config_node` - Docker updated, previously: `circleci/node:8-browsers`
@andygout
Copy link
Contributor Author

Checks performed:

  • Unit tests are passing.

There is some usage of Array.prototype.sort in lib/promise-surviver.js which was mentioned as having its functionality changed in a Node version which this repo surpasses in this PR (ref. nodejs/node#24294), but I have already checked another repo with a similar case and this usage of sort was unaffected.

@andygout andygout merged commit aee70af into master Sep 28, 2020
@andygout andygout deleted the upgrade-node-to-v14 branch September 28, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants