update types/part_set.go #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ulbqb
approved these changes
Jul 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 66.12% 66.10% -0.02%
==========================================
Files 277 275 -2
Lines 36992 36930 -62
==========================================
- Hits 24462 24414 -48
+ Misses 10756 10750 -6
+ Partials 1774 1766 -8
|
ulbqb
added
the
C: enhancement
torao
approved these changes
Jul 4, 2023
|
Thank you @mansub-song for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm looking at the ostracon code and came across the annotation that I found awkward.
I found that the same comment is described not only in ostracon but also in cometBFT, so I changed cometBFT first and my proposal was approved.
Here is the related link: cometbft/cometbft#1056
In
types/params.go, the value of BlockPartSizeBytes is 65536 (about 64kB).In the function
func NewPartSetFromData(data []byte, partSize uint32) *PartSetintypes/part_set.go, the function uses the parameterpartSizewhich is the value of BlockPartSizeBytes.However, the annotation says it's 4kB, so I'm doing a pull request to fix it.