feat: copy callee's event manager's info to caller before callee is destructed #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loloicci
force-pushed
the
dynamic-event-manager
branch
2 times, most recently
from
d64bbff
to
95c6f43
Compare
loloicci
force-pushed
the
dynamic-event-manager
branch
4 times, most recently
from
3656ec5
to
f89317c
Compare
loloicci
force-pushed
the
dynamic-event-manager
branch
3 times, most recently
from
5099e00
to
5904127
Compare
|
CI fails with a race error and this error is caused even without this PR. A test added with this PR catch the race error of the |
da1suk8
reviewed
Mar 6, 2023
| @@ -312,6 +312,19 @@ impl BackendApi for GoApi { | |||
| }; | |||
| gas_info.cost += callee_instance.create_gas_report().used_internally; | |||
|
|
|||
| // copy callee event manager's info to caller instance | |||
| if !callee_instance.env.is_storage_readonly() { | |||
There was a problem hiding this comment.
Why does the callee instance only copy to the caller when it has read-write permission?
There was a problem hiding this comment.
This is because events can be issued by instances having write permission.
da1suk8
approved these changes
Mar 7, 2023
8 tasks
Kynea0b
approved these changes
Mar 23, 2023
|
closes because after Finschia/cosmwasm#273, it is not needed |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a hook before destructing callee instance to copy callee's event manager's information to caller's. This enables callee contract issues events/attributes via its event manager API's.
This PR solves the 3rd part of Finschia/cosmwasm#265.
Now, this PR is a draft because it uses loloicci's repository, and after Finschia/cosmwasm#269 is merged, it will be replaced.
Types of changes
Checklist