-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Census tract #543
base: develop
Are you sure you want to change the base?
Census tract #543
Conversation
Summary of changesUpdated the department details map to display an optional vector tile layer composed of census tracts. Each of the tracts is color-coded to match the population density of the county they belong to. The map should only show the census tracts for the state in which the fire department is located. List of changes(Be sure to list any refactorings or unexpected changes)
CaveatsLinks to relevant issues(Mark as Links to related pull requestsLinks to relevant documentation (Notion, external)Example screenshots, gifs, or videosShould this pull request be tested any more or less than usual?What code can others reuse?What are general test steps or cases?
Thank you!
|
resolving codacy issues resolving codacy issues resolving codacy issue
dadf820
to
ac6c9f4
Compare
…cations removed the feature outline color
18749dc
to
a643cf7
Compare
@davidplummer-pe is there a click handler on there to show the population density when a user clicks the geometry? Also, how does this look without the white stroke? |
@garnertb no, there's no click event in place. The branch actually has the white outline removed from the polygons. The screenshot I uploaded before was outdated. It's been replaced. |
Ok, without a legend, I think the click event is necessary so the user has
context as to what each color means.
…-Tyler
On Thu, Jul 16, 2020 at 4:09 PM David Plummer ***@***.***> wrote:
@garnertb <https://github.com/garnertb> no, there's no click event in
place. The branch actually has the white outline removed from the polygons.
The screenshot I uploaded before was outdated. It's been replaced.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#543 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIWXDVA2OVIFB76LL2VGITR35M77ANCNFSM4OU6VQGA>
.
--
-Tyler Garner
|
Alright then, I'll add it. |
@garnertb is this what you had in mind? |
No description provided.