Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Census tract #543

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Census tract #543

wants to merge 6 commits into from

Conversation

joliveros
Copy link
Contributor

No description provided.

@joliveros joliveros added the WIP Work-In-Progress label Jul 8, 2020
@davidplummer-pe
Copy link
Contributor

davidplummer-pe commented Jul 10, 2020

Summary of changes

Updated the department details map to display an optional vector tile layer composed of census tracts. Each of the tracts is color-coded to match the population density of the county they belong to. The map should only show the census tracts for the state in which the fire department is located.

List of changes

(Be sure to list any refactorings or unexpected changes)

  • added a new service
  • updated the department controller to load the census tracts layer

Caveats

Links to relevant issues

(Mark as Fixes #<GITHUB_ISSUE_NUMBER> to automatically close the GitHub issue.
This will also backlink the issue to the pull request in the issue header.
Also, make sure to update the issues with any important details)

Links to related pull requests

Links to relevant documentation (Notion, external)

Example screenshots, gifs, or videos

0001

2.

0002

3.

Screen Shot 2020-07-16 at 4 04 25 PM

4.

Screen Shot 2020-07-17 at 1 38 50 PM

Screen Shot 2020-07-17 at 1 38 37 PM

Screen Shot 2020-07-17 at 1 39 00 PM

Should this pull request be tested any more or less than usual?

What code can others reuse?

What are general test steps or cases?

  1. Launch the firecares web app & login.
  2. Click on the departments tab in the header.
  3. Click on any of the departments listed in the search results.
  4. Wait about 20-30 seconds for all of the layers to finish loading.
  5. Open the layers list in the map view and activate the census tracts layer.
    assumption: all of the census tracts for the department's state should be painted on the map (see photo 3 above)
  6. Toggle the census tracts map layer off.
    assumption: the census tracts layer should disappear
  7. Toggle the census tracts map layer back on and click on a blue census tract feature.
    assumption: you should see a popup similar to image 4 above showing the area class and the population density
  8. Click on a green census tract feature.
    assumption: you should see a popup similar to either image 5 or 6 above showing the area class and the population density

Thank you!


Here are guidelines and a checklist we've used at times that can be helpful for some projects:

```jsx
Pull Request Expectations
-------------------------

See the Working Agreements in the Notion project page for additional considerations.

Guidelines
==========

- The Reviewer is encouraged to ask questions and share suggestions.
- The Reviewer must make it clear what comments are not mandatory.
- The Reviewer must let the Submitter know if modifying the branch.
- The Submitter is encouraged to backlog any larger changes.
- The Submitter makes the final call on any issue not consider a bug.
- The Submitter should merge in the code unless otherwise discussed.
- The Submitter should ensure relevant details exist in other systems as well.

Submitter checklist
===================

Branching, Rebasing, and Merging

- Branch off of `develop` typically.
- Only branch from a feature branch if it is unlikely to change before merge.
- Prefix branches with `feature/` or `bugfix/`.
- Rebase early and often. Use Merge if there are too many risky conflicts.

Before assigning reviewers

- [x] Review your own code before assigning to others.
- [x] Rebase or merge from develop branch.
- [ ] Do a smoke test after all merges
- [ ] Review the QA section on the Project page for regression test cases.
- [ ] Look for any TODOs, dead code, or unnecessary log statements.

Information Sharing

- [x] Announce any important changes in Slack
- [x] Update the project board task status and fill in any extra information.
- [x] Update the project board with any issues or future improvements.
- [ ] Update the README.md
- [ ] Update Notion project page
- [ ] Update Notion technology pages

Reviewer checklist
==================

As a reviewer, it is suggested that anything is fair game to comment, but style or
implementation approach should be respected and at the discretion of the submitter,
unless it substantially affects the architecture of the codebase. 

- [ ] Make it clear whether each comment is a bug, a suggestion, or just an FYI.
- [ ] Look for any TODOs, dead code, or unnecessary log statements.
- [ ] Brainstorm any additional test cases.
- [ ] Pull down and test the code in all but the most simple pull requests.

💔Thank you!

resolving codacy issues

resolving codacy issues

resolving codacy issue
@garnertb
Copy link
Contributor

@davidplummer-pe is there a click handler on there to show the population density when a user clicks the geometry? Also, how does this look without the white stroke?

@davidplummer-pe
Copy link
Contributor

@garnertb no, there's no click event in place. The branch actually has the white outline removed from the polygons. The screenshot I uploaded before was outdated. It's been replaced.

@garnertb
Copy link
Contributor

garnertb commented Jul 17, 2020 via email

@davidplummer-pe
Copy link
Contributor

Alright then, I'll add it.

@davidplummer-pe
Copy link
Contributor

@garnertb is this what you had in mind?
Screen Shot 2020-07-17 at 1 38 37 PM
Screen Shot 2020-07-17 at 1 38 50 PM
Screen Shot 2020-07-17 at 1 39 00 PM

@joliveros joliveros changed the title WIP - Census tract Census tract Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work-In-Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants