update to net8.0 #2442
update to net8.0 #2442
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Update README target version section please |
|
Hey guys, is anything blocking this PR other than the readme change? Net7 has reached end of life, it's time to move on... |
|
Believe so, let's get readme updated and merge dev in. |
# Conflicts: # Flow.Launcher.Core/Flow.Launcher.Core.csproj # Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj
# Conflicts: # Flow.Launcher.Core/Flow.Launcher.Core.csproj # Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj # Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
WalkthroughWalkthroughThe changes involve updating multiple project files across a .NET application to target .NET 8.0 instead of .NET 7.0. This includes modifications to package references, resource inclusions, and publish profiles, ensuring the entire codebase aligns with the new framework version. The updates enhance compatibility with the latest framework features and improve resource management. Changes
Assessment against linked issues
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files skipped from review due to trivial changes (1)
Additional context usedLearnings (1)
Additional comments not posted (16)
Tip Early access features: disabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This comment has been minimized.
This comment has been minimized.
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…er found their windows version doesn't work) and update some dependency
|
@jjw24 so far everything works for me. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@taooceros also need to update sdk version and TFMs here: https://github.com/Flow-Launcher/Flow.Launcher/blob/dev/.github/workflows/default_plugins.yml |
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. Pattern suggestions ✂️ (1)You could add these patterns to If the flagged items are 🤯 false positivesIf items relate to a ...
|
|
🥷 Code experts: Yusyuriv, jjw24 Yusyuriv, VictoriousRaptor have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
fix #2426
I seem to have issue to load icon for setting panel. Could anyone reproduce that?This is caused by low version ofSystem.Drawing.Common. We may want to update other dependency as well.Somehow that works for me before but not now. Don't know what's going on.Might be some weird caching issue. Seems like if the resources font has the same name as one of the fonts installed by system it won't get loaded. So I rename the font to have the space replaced by-System.Drawing.Common,FSharp.Core,Microsoft.Data.Sqliteto 8.0.0