Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.json dependencies broken in 3.2.0 #52

Closed
fcool opened this issue Oct 27, 2021 · 5 comments · Fixed by #53
Closed

composer.json dependencies broken in 3.2.0 #52

fcool opened this issue Oct 27, 2021 · 5 comments · Fixed by #53

Comments

@fcool
Copy link
Contributor

fcool commented Oct 27, 2021

jobqueue-common 3.2.0 claims to be compatible with Flow 4.0.

But with 221c7c5 a Flow 5.x onwards dependency has been introduced.

So what to do: Drop Flow 4.0 compatibility or provide something to get it running in Flow 4.x again? (Which is not soooo easy, if it should run in 6.x as stated, too)

@bwaidelich
Copy link
Contributor

Thanks for taking the time to write this up! I think we can safely drop support for Flow 4

@fcool
Copy link
Contributor Author

fcool commented Oct 27, 2021

I think so, too - as Flow 4.x is generally not supported any longer ;)

I would create a PR to drop the compatibility and would suggest we relaese a 3.2.1 and delete the 3.2.0 so no old installations would try to fetch this "broken" release, what do you think?

@bwaidelich
Copy link
Contributor

Yes, makes sense. Thanks!

fcool added a commit to fcool/jobqueue-common that referenced this issue Oct 27, 2021
bwaidelich pushed a commit that referenced this issue Oct 27, 2021
@bwaidelich
Copy link
Contributor

Fixed with https://github.com/Flowpack/jobqueue-common/releases/tag/3.2.1 and I removed 3.2.0 from packagist.
Thanks again!

@fcool
Copy link
Contributor Author

fcool commented Oct 27, 2021

https://packagist.org/packages/flowpack/jobqueue-common still lists 3.2.0

Did it fetch it again?
I guess we need to remove the Tag from the repository to be sure, it wont get fetched again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants