BUGFIX: When working on job, catch Throwable #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on a job, any `\Exception` is caught and the job in the queue is released (retry or failure). In case of a `\Throwable` _not_ being an `\Exception`, this does not happen and the job is never "un- reserved". This change catches `\Throwable` instead to fix this.
bwaidelich
reviewed
Jul 28, 2022
| $maximumNumberOfReleases = isset($queueSettings['maximumNumberOfReleases']) ? | ||
| (int)$queueSettings['maximumNumberOfReleases'] : | ||
| self::DEFAULT_MAXIMUM_NUMBER_RELEASES; | ||
| if ($message->getNumberOfReleases() < $maximumNumberOfReleases) { | ||
| $releaseOptions = isset($queueSettings['releaseOptions']) ? $queueSettings['releaseOptions'] : []; | ||
| $queue->release($message->getIdentifier(), $releaseOptions); | ||
| $this->emitMessageReleased($queue, $message, $releaseOptions, $exception); | ||
| $logMessage = $this->throwableStorage->logThrowable($exception); | ||
| $this->emitMessageReleased($queue, $message, $releaseOptions, $throwable); |
There was a problem hiding this comment.
Doh, this part now fails if $throwable is an \Error – and changing the signal signature would be a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on a job, any
\Exceptionis caught and the job in thequeue is released (retry or failure). In case of a
\Throwablenotbeing an
\Exception, this does not happen and the job is never "un-reserved".
This change catches
\Throwableinstead to fix this.