WIP: Variants Editor #177
Draft
WIP: Variants Editor #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahaeslich
reviewed
Feb 15, 2023
| }: VariantProps) => { | ||
| const classes = useStyles(); | ||
| // TODO: Find out why we need to check both |
There was a problem hiding this comment.
Are you wondering why there can exist variants without an preset identifier in a Neos installation?
There was a problem hiding this comment.
I guess thats because custom crops (e.g. in Fusion) are also stored as variants and have no preset identifier?
I took that code from the current media browser version, and I am wondering why a variant with preset identifier should not be croppable, and more important: why does checking for an existing crop area ensure that the image is croppable. If I have a 16:9 image and a 16:9 preset, technically there is no need for a crop area over the whole image, but I should still be able to choose a smaller area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an Editor for image variants.
Resolves: #34
Current todos: