Add `resolutionHost` option #3

j6s · 2019-04-23T14:14:22Z

This is a PR for a fork that is not mine! (I didn't know that was possible either)

I just happened to stumble upon this fork containing 2 of the things that I wanted:

An resolutionHost option that allows resolution based on the hostname
A readme.md describing how the plugin works

With the resolutionHost option you can replace the complete hostname based on your content dimensions.

MarcoPNS · 2019-07-25T13:38:38Z

Hi @j6s ! Thanks for stumbling across my fork. to be honest it is not quite finished yet. You can not use the resolutionHost option in the uriPathSegment mode yet. Everything else already works.

update to current commit

MarcoPNS · 2020-08-10T13:54:46Z

Just a small hint that this PR does not work for Neos 5.x yet - Need to wait till neos/neos-development-collection#2803 get accepted.

MarcoPNS · 2020-08-15T17:45:38Z

Did some testing and the resolutionHost value now works with all modes but still need to wait for the other PR in the Neos Core.

MarcoPNS · 2021-01-05T16:40:53Z

Works with Neos 7 🎉 MarcoPNS@e5b05a7

kdambekalns

The changes to the documentation need to be merged into the README.md that exists since #12

kdambekalns

Oh, and please undo the permission changes on the PHP files, those do not need to be executable.

kdambekalns · 2023-08-30T07:44:26Z

composer.json

+        "neos/neos": "~4.0||~5.0||~7.0||~8.0 || dev-master",
+        "neos/flow": "~5.0||~6.0||~7.0||~8.0 || dev-master"


Suggested change

"neos/neos": "~4.0||~5.0||~7.0||~8.0 || dev-master",

"neos/flow": "~5.0||~6.0||~7.0||~8.0 || dev-master"

"neos/neos": "^7.0 || ^8.0 || dev-master",

"neos/flow": "^7.0 || ^8.0 || dev-master"

kdambekalns · 2023-08-30T07:46:38Z

Classes/Routing/FrontendNodeRoutePartHandler.php

@@ -482,6 +513,6 @@ protected function getRequestPathByNode(NodeInterface $node)
            $currentNode = $currentNode->getParent();
        }

-        return implode('/', array_reverse($requestPathSegments));
+        return '/' . implode('/', array_reverse($requestPathSegments));


kdambekalns · 2023-08-30T07:46:56Z

Classes/Routing/FrontendNodeRoutePartHandler.php

@@ -422,6 +421,7 @@ protected function resolveRoutePathForNode(NodeInterface $node)
     *
     * @param NodeInterface $siteNode The site node, used as a starting point while traversing the tree
     * @param string $relativeRequestPath The request path, relative to the site's root path
+     * @deprecated Use getNodeFromRequestPath() - return only the node


kdambekalns · 2023-08-30T07:47:06Z

Classes/Routing/FrontendNodeRoutePartHandler.php

@@ -409,8 +409,7 @@ protected function resolveRoutePathForNode(NodeInterface $node)
        $nodeContextPathSuffix = ($workspaceName !== 'live') ? substr($nodeContextPath, strpos($nodeContextPath, '@')) : '';

        $requestPath = $this->getRequestPathByNode($node);
-
-        return trim($requestPath, '/') . $nodeContextPathSuffix;
+        return $requestPath . $nodeContextPathSuffix;


kdambekalns · 2023-08-30T07:47:36Z

Classes/Routing/FrontendNodeRoutePartHandler.php

-            $relativeNodePath = $this->getRelativeNodePathByUriPathSegmentProperties($siteNode, $requestPathWithoutContext);
-            $node = ($relativeNodePath !== false) ? $siteNode->getNode($relativeNodePath) : null;
+            $node = $this->getNodeFromRequestPath($siteNode, $requestPathWithoutContext) ?? null;


This will conflict with #11 I think. Just pointing this out already…

MarcoPNS · 2023-09-08T07:01:43Z

@kdambekalns It's been sooo long. I can no longer answer exactly why. I would first have to work my way back into it.

kdambekalns · 2024-07-02T17:30:05Z

I just looked at this again… @MarcoPNS if you still use this and have interest in it, I'd suggest we do this:

I see to it that TASK: Update FrontendNodeRoutePartHandler to current "original" #13 is merged 🧹
You explain to me a bit more how that resolutionHost is to be used (I did not really understand it from the README part you added) 🤓
We create a new PR for that feature ✨

If you can't help, I suggest we close this. 🤷‍♂️

MarcoPNS · 2024-07-04T06:51:23Z

Hi! There are cases where the options are not strict enough. I had projects where the domains looked like this:

de.example.com
es.example.com
www.example.es
www.example.com

Each domain leads to a separate dimension.

So the resolutionHost value was born to handle this type of case. The handling gets more complicated in case of multisites or if you want to mix the modes where you may have cases like this:

beispiel.de ('site-a')
sub.beispiel.de ('site-b')
example.com ('site-a')
sub.example.com ('site-b')
example.com/fr ('site-a')
sub.example.com/fr ('site-b')
sub.example.com/promo ('site-c')

As the feedback here was a bit limited, we started to develop an in-house solution for this and wrote a closed source package. If this is something that is also interesting here, I could implement it. This would get rid of the resolutionMode because it's not needed anymore. Config could look like this:

Neos:
  ContentRepository:
    contentDimensions:
      'language':
        label: 'Languages'
        icon: 'language'
        default: 'en'
        defaultPreset: 'en'
        uriSegmentHost: 'example.com'
        presets:
          'de':
            label: 'Deutsch'
            values: ['de']
            uriSegment: 'de'
            hosts:
              'site-a': 'beispiel.de'
              'site-b': 'sub.beispiel.de'
          'en':
            label: 'English'
            values: ['en']
            uriSegment: 'en'
            hosts:
              'site-a': 'example.com'
              'site-b': 'sub.example.com'
          'fr':
            label: 'France'
            values: ['fr']
            uriSegment: 'fr'
            hosts:
              'site-a': 'example.com/fr'
              'site-b': 'sub.example.com/fr'

MarcoPNS added 3 commits March 15, 2019 17:03

added new option resolutionHost

ae88949

With the resolutionHost option you can replace the complete hostname based on your content dimensions.

edited docuentation and renamed it for github

b3b34f7

added missing Syntax highlighting in readme file

8b536bd

MarcoPNS and others added 2 commits November 26, 2019 10:41

Merge remote-tracking branch 'upstream/master'

33436c7

Merge pull request #1 from Flowpack/master

0c4f9e4

update to current commit

host can be used with uriPathSegment

0d0ce64

Switched to PSR-15 middleware for Neos 7.0

e5b05a7

bwaidelich changed the title ~~Add resoultionHost option~~ Add resolutionHost option Jan 5, 2021

MarcoPNS mentioned this pull request Jan 8, 2021

Switched to PSR-15 middleware for Neos 7.0 #8

Merged

MarcoPNS added 2 commits January 8, 2021 15:32

renamed DetectContentSubgraphComponent

a0f2334

renamed SubgraphMiddleware file

5216ace

kdambekalns added the enhancement label Feb 10, 2021

MarcoPNS added 2 commits July 13, 2021 12:52

Fix for PSR-7 v2

6b601f3

Merge branch 'master'

3afe9a2

kdambekalns requested changes Aug 30, 2023

View reviewed changes

kdambekalns reviewed Aug 30, 2023

View reviewed changes

kdambekalns self-assigned this Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `resolutionHost` option #3

Add `resolutionHost` option #3

j6s commented Apr 23, 2019

MarcoPNS commented Jul 25, 2019 •

edited

Loading

MarcoPNS commented Aug 10, 2020

MarcoPNS commented Aug 15, 2020

MarcoPNS commented Jan 5, 2021 •

edited

Loading

kdambekalns left a comment

kdambekalns left a comment

kdambekalns Aug 30, 2023

kdambekalns Aug 30, 2023

kdambekalns Aug 30, 2023

kdambekalns Aug 30, 2023

kdambekalns Aug 30, 2023 •

edited

Loading

MarcoPNS commented Sep 8, 2023 •

edited

Loading

kdambekalns commented Jul 2, 2024

MarcoPNS commented Jul 4, 2024 •

edited

Loading

		"neos/neos": "~4.0\|\|~5.0\|\|~7.0\|\|~8.0 \|\| dev-master",
		"neos/flow": "~5.0\|\|~6.0\|\|~7.0\|\|~8.0 \|\| dev-master"

Add resolutionHost option #3

Are you sure you want to change the base?

Add resolutionHost option #3

Conversation

j6s commented Apr 23, 2019

MarcoPNS commented Jul 25, 2019 • edited Loading

MarcoPNS commented Aug 10, 2020

MarcoPNS commented Aug 15, 2020

MarcoPNS commented Jan 5, 2021 • edited Loading

kdambekalns left a comment

Choose a reason for hiding this comment

kdambekalns left a comment

Choose a reason for hiding this comment

kdambekalns Aug 30, 2023

Choose a reason for hiding this comment

kdambekalns Aug 30, 2023

Choose a reason for hiding this comment

kdambekalns Aug 30, 2023

Choose a reason for hiding this comment

kdambekalns Aug 30, 2023

Choose a reason for hiding this comment

kdambekalns Aug 30, 2023 • edited Loading

Choose a reason for hiding this comment

MarcoPNS commented Sep 8, 2023 • edited Loading

kdambekalns commented Jul 2, 2024

MarcoPNS commented Jul 4, 2024 • edited Loading

Add `resolutionHost` option #3

Add `resolutionHost` option #3

MarcoPNS commented Jul 25, 2019 •

edited

Loading

MarcoPNS commented Jan 5, 2021 •

edited

Loading

kdambekalns Aug 30, 2023 •

edited

Loading

MarcoPNS commented Sep 8, 2023 •

edited

Loading

MarcoPNS commented Jul 4, 2024 •

edited

Loading