Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update get_emb_sz method #167

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

manikyabard
Copy link
Contributor

Updates get_emb_sz to ensure the order of embedding sizes is as expected which might not have been the case with just using Dict key order.

@darsnack
Copy link
Member

darsnack commented Sep 4, 2021

Code changes look fine, but I am wondering whether we should just drop the Dict version. I get that it is easier to specify a single column override with the Dict, but it is really not that hard to generate a vector of overrides + nothing with a generator. It's so deep into the API hierarchy too that we can forgo the same level of convenience we apply to the top level functions.

And if the consuming model building function always expects an in-order vector, then the Dict approach doesn't really make sense.

@manikyabard
Copy link
Contributor Author

Yeah, that does make sense. I think I'll then just remove the method which takes in a Dict, and update the tabularclassification notebook to show an example of using custom embedding sizes for people new to FastAI.jl or julia.

@lorenzoh
Copy link
Member

lorenzoh commented Sep 7, 2021

Thanks Manikya for the change! Is this ready to merge?

@manikyabard
Copy link
Contributor Author

If everything looks okay with the changes, then yeah it should be.

@lorenzoh lorenzoh merged commit 084140e into FluxML:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants