Move domain-specific functionality to submodules #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now the variable name `data` had been used ambiguously to refer to both a data container and an instance of data in the context of a block. The latter has now been renamed to `obs` for clarity.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensive refactoring that splits up functionality by domains. Specifically:
FastAI.VisionFastAI.TabularSymbols from the submodules are reexported, so this does not change
FastAI's exports.As additional refactoring, this PR separates
Blockimplementations to their own files which also include implementations of optional interfaces likeshowblock!orblocklossfnas well as inline tests (using InlineTest.jl). The exception are blocks that are specific to a single encoding (e.g.KeypointTensortoKeypointPreprocessing); these remain in the files of their respective encoding.This PR theoretically makes it possible to move domain-specific functionality into their own packages. Not sure if that makes sense at this point though.
To-Dos:
VisionTabular