Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor's Guide draft #1824

Merged
merged 13 commits into from
Jan 22, 2022
Merged

Conversation

lilianabs
Copy link
Contributor

@logankilpatrick, @DhairyaLGandhi can you please have a look at this first draft? Some sections are incomplete and it'd be very helpful if you could give me some feedback on the current content :)

@logankilpatrick
Copy link
Member

This is an awesome first pass!! Nothing big jumps out at me as having to be addressed so far. Any additional thoughts @DhairyaLGandhi ?

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes. This is amazing, thank you!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@darsnack darsnack mentioned this pull request Jan 12, 2022
14 tasks
@DhairyaLGandhi
Copy link
Member

I get the sense that we need to give more emphasis to writing tutorials and models in addition to the core functionality. We should also talk about the information to be included in an issue and PR and how to present it best. One is to limit PRs to make only the necessary changes, and write motivating tests before hand.

Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
Copy link
Member

@DhairyaLGandhi DhairyaLGandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! This is shaping up really well. I've left a few thoughts on the document so far.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
Comment on lines 122 to 124
* [How to file a bug report]()
* [How to submit a contribution]()
* [Flux source code organisation]()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should link to the appropriate sections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links fixed. Just a question: does it makes sense to have the section Flux source code organisation? I haven't finished that section and just wondering if it's worth it.

lilianabs and others added 8 commits January 17, 2022 13:39
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
@lilianabs
Copy link
Contributor Author

@logankilpatrick, @DhairyaLGandhi, @darsnack I've added the suggestions. Could you please have a look at the section Flux source code organization and comment on it. Do you think is worth having it?

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@lilianabs lilianabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated :)

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lilianabs!

@darsnack darsnack merged commit 5acf9e1 into FluxML:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants