Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing overloads for Tridiagonal #1362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChrisRackauckas
Copy link
Member

Upstreaming from DiffEqFlux (SciML/DiffEqFlux.jl#800)

@ToucheSir
Copy link
Member

Are there tests to be upstreamed as well? Seems like this could fix #455 too.

@ChrisRackauckas
Copy link
Member Author

The tests are really just the downstream DiffEqFlux tests. There's no simple test right now that we can upstream here, it's deep in a deep code (comes from SplineLayer which pulls in DataInterpolations etc.). Someone can probably dig in and make a test out of that.

@mcabbott
Copy link
Member

This looks like what JuliaDiff/ChainRulesCore.jl#446 is meant to fix. Can you check easily?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants