Add rule for push!(::IdSet)
#1494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
added
needs adjoint
|
NNlib reverse CI will be fixed by FluxML/NNlib.jl#559. DynamicPPL tests still appear unrelated. Remaining failures (not errors) don't use implicit params, and may be related to ChainRules since they're testing those rules rather than Zygote ones. |
This is required on 1.11 because the underlying implementation has changed.
ToucheSir
force-pushed
the
bc/idset-push!
branch
from
ef1b2da
to
fe6d2f0
Compare
|
Revisiting this because it squashes one error on nightly that is making all PRs fail. It does expose another error related to try-catch, but I imagine #1474 would help with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required on 1.11 because the underlying implementation changed in JuliaLang/julia@cb01a3b from using an IdDict (which Zygote can diff through) to a direct
ccall.PR Checklist
Documentation, if applicable