Allowing blocking calls inside Jackson's DeserializerCache::_createAndCacheValueDeserializer resolves the IllegalMonitorStateException #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dCacheValueDeserializer resolves the IllegalMonitorStateException
softqwewasd
requested review from
TommyPersson,
splitfeed,
jepp3,
nolexa and
magnusp
|
splitfeed
reviewed
Jun 17, 2024
TommyPersson
approved these changes
Jun 17, 2024
Pretty much. I've updated the PR description with some additional context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing blocking calls inside Jackson's DeserializerCache::_createAndCacheValueDeserializer resolves the IllegalMonitorStateException.
See FasterXML/jackson-databind#4430
This PR resolves the issue we had when upgrading to Jackson 2.17.1. The upgrade to 2.17.1 caused some of our tests to fail with IllegalMonitorStateException. By configuring Blockhound to allow blocking calls inside _createAndCacheValueDeserializer, IllegalMonitorStateException is no longer thrown. You can read more about this issue here FasterXML/jackson-databind#4430 (comment).