Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default file type to MP3 (#35) #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Feb 26, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Changed default file type to MP3, and also switched order in the dialog, so the default option is the first one.

Fixes the following issue(s)

Acknowledgement

@David-Else
Copy link

While DEFAULT_BITRATE = 128000 is fine for Opus, it is not good for AAC and terrible for MP3. Please consider at least 192, ideally 320. If there is going to be a default for all codecs then maybe DEFAULT_BITRATE = 192000 would be better, but separate defaults would be ideal.

128k MP3 is widely regarded as terrible sounding, it was only a thing 20 odd years ago when people were putting ripped albums on a 256meg USB stick, there is absolutely no need for it in this day and age. This is still true for voice recordings on mobile phones, which I am sure this app is widely used for. I read in another issue that Opus was not being used yet due to Android compatibility, MP3 can sound decent, but just not at 128k.

Thanks for all the work on this great app, cheers!

@Aga-C
Copy link
Member Author

Aga-C commented Feb 27, 2024

@David-Else You're right, 128 kbps as the default for MP3 doesn't make sense. I've changed it to 192 kbps. However, I don't think separate default values are needed - when someone changes file type, the bitrate setting is right below, so it shouldn't be the problem to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mp3 should be the automatic file extension type
2 participants