Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get permission service: clean "can_request_help" usage #1004

Closed
3 tasks done
smadbe opened this issue Sep 6, 2023 · 0 comments · Fixed by #1006
Closed
3 tasks done

Get permission service: clean "can_request_help" usage #1004

smadbe opened this issue Sep 6, 2023 · 0 comments · Fixed by #1006
Assignees

Comments

@smadbe
Copy link
Contributor

smadbe commented Sep 6, 2023

Motivations

The current spec of the service does not really work how the "can_request_help" is designed. So let's fix it.

Subtasks

  • in computed and all granted_via_*, can_request_help_to is aggregate of several groups, so return an array of the (id, is_all_users_group, name) tuple. This should be [] is there is no such groups.
  • in granted, the can_request_help_to is unique to keep (id, is_all_users_group, name). can_request_help_to should be null if there is no value set.
  • In both cases, if a group is not visible by the current user, the name should not be given, but the id or is_all_users_group should be given in any case.
GeoffreyHuck added a commit that referenced this issue Sep 8, 2023
…s for group_membership, item_unlocking, self and other

Also changed the structure of a can_request_help_to permission: id, is_all_users_group and name are now always present. It improves consistency.
Not implemented for computed yet
@see #1004
GeoffreyHuck added a commit that referenced this issue Sep 8, 2023
…s for group_membership, item_unlocking, self and other

Also changed the structure of a can_request_help_to permission: id, is_all_users_group and name are now always present. It improves consistency.
Not implemented for computed yet
@see #1004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants