Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment that can fix TypeScript errors with Yarn #2800

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

spidgorny
Copy link
Contributor

With Yarn 2 TypeScript can't find @types/... files in node_modules (because it does not exist). This is a workaround for such situation.

Changes

Testing

Docs

With Yarn 2 TypeScript can't find @types/... files in node_modules (because it does not exist). This is a workaround for such situation.
@vercel
Copy link

vercel bot commented Mar 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/6Gu65Aac69wtndkRQfxXtgCojtHL
✅ Preview: https://snowpack-git-fork-spidgorny-patch-1-pikapkg.vercel.app

@FredKSchott
Copy link
Owner

Yarn v2 really doesn't support @types? That's pretty surprising!

More for style than anything, I'd like to move this note from the config file to the README. Mind moving it to a note in the README?

@spidgorny
Copy link
Contributor Author

@spidgorny
Copy link
Contributor Author

Typescript does not support yarn 2 folder structure directly.
Issue: microsoft/TypeScript#28289
More info: https://medium.com/swlh/getting-started-with-yarn-2-and-typescript-43321a3acdee

@FredKSchott
Copy link
Owner

Yup, that's the readme that every start application gets (and a good place to leave notes for people after they initialize the template)

@melissamcewen melissamcewen marked this pull request as draft March 16, 2021 20:47
@melissamcewen
Copy link
Contributor

Hey @spidgorny if you add it to the readme, you can convert from draft, assign me as a reviewer and I'll merge it

@FredKSchott FredKSchott self-assigned this Mar 17, 2021
@spidgorny
Copy link
Contributor Author

you can convert from draft

Not sure what you mean with that. Anyway, I've tried to explain the situation and a workaround in the README.

@melissamcewen, please check.

@FredKSchott FredKSchott marked this pull request as ready for review March 31, 2021 01:22
@FredKSchott
Copy link
Owner

Thanks for the contribution @spidgorny, LGTM!

@FredKSchott FredKSchott merged commit 6bde3cf into FredKSchott:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants