Make it so that the BUILD_ID is only ever read once in the server lifetime #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is in response to a suggestion bylubieowoce to make it so that we don't read the BUILD_ID on every request https://x.com/lubieowoce/status/1741255877108101466?s=20
I couldn't make it so that the BUILD_ID is exported at the top of the file since next will try to compile the file and throw an error because the file
.next/BUILD_IDdoesn't exist at build time. So to mitigate this, we replaced thecachefunction from next with our customlifetimeCachefunction which caches the results of operations for the whole the server lifetime, this way the BUILD_ID isn't read at build time, but only read at runtime once.Type of Change