Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance for issue search list default query #125

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

Fredkiss3
Copy link
Owner

Description

When navigating to the issues' list page, it is slow for users, this is because the default query uses ilike in body,title and comments even though the query is empty

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gh-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 9:01pm

@Fredkiss3
Copy link
Owner Author

Ok, it seems that the issue is elsewhere, even when the page is prefetched, the navigation is not instant and what is prefetched is not even the page but a weird payload, like this :

0:["FOL33qzeHgGMrRmKdtGJc",[["children","(app)","header_subnav","children","children",["user","Fredkiss3","d"],"children",["repository","gh-next","d"],"children","[...pages]",["[...pages]",{"children":["__PAGE__",{}]}],null,null],["children","(app)","page_title","children","children",["user","Fredkiss3","d"],"children",["repository","gh-next","d"],"children","[...pages]",["[...pages]",{"children":["__PAGE__",{}]}],null,null],["children","(app)","children",["user","Fredkiss3","d"],"children",["repository","gh-next","d"],"children","issues",["issues",{"children":["__PAGE__",{}]}],null,null]]]

@Fredkiss3 Fredkiss3 merged commit b520654 into main Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant