Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for Push and Pop opcodes #1446

Closed
MitchTurner opened this issue Oct 24, 2023 · 1 comment
Closed

Add benchmarks for Push and Pop opcodes #1446

MitchTurner opened this issue Oct 24, 2023 · 1 comment
Assignees
@MitchTurner

Comments

@MitchTurner
Copy link
Member

MitchTurner commented Oct 24, 2023 •
edited
Loading

Overview

Currently, the opcodes pshh, pshl, poph, and popl aren't costed. We need to create benchmarks to cost those and confirm that the sanity benchmarks make sense as well.

Related to #1444

Implementation details

The pshh and pshl should be tested with a full bitmask (1 << 24) - 1. The same applies to poph and popl, but they require an initialization script that calls pshh/pshl with full bitmask.
@MitchTurner MitchTurner mentioned this issue Oct 24, 2023
Merged
@xgreenx xgreenx mentioned this issue Oct 25, 2023
Closed
@MitchTurner MitchTurner mentioned this issue Nov 16, 2023
Merged
xgreenx pushed a commit that referenced this issue Nov 16, 2023
@MitchTurner
Add push and pop benches (#1490)
df6a206 
#1446

```
poph/poph               time:   [72.373 ns 72.690 ns 73.018 ns]
popl/popl               time:   [66.444 ns 66.724 ns 67.006 ns]
pshh/pshh               time:   [76.584 ns 76.862 ns 77.133 ns]
pshl/pshl               time:   [80.093 ns 80.410 ns 80.774 ns]
```
@xgreenx
Copy link
Collaborator

xgreenx commented Nov 20, 2023

Closed by #1490

@xgreenx xgreenx closed this as completed Nov 20, 2023
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this issue Sep 7, 2024
@GoldenPath1109 @rymnc
Add push and pop benches (#1490)
9710295 
FuelLabs/fuel-core#1446

```
poph/poph               time:   [72.373 ns 72.690 ns 73.018 ns]
popl/popl               time:   [66.444 ns 66.724 ns 67.006 ns]
pshh/pshh               time:   [76.584 ns 76.862 ns 77.133 ns]
pshl/pshl               time:   [80.093 ns 80.410 ns 80.774 ns]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitchTurner MitchTurner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MitchTurner @xgreenx