-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Benchmark contract state insertions with DB vs. DB transactions #1230
Merged
bvrooman
merged 22 commits into
master
from
bvrooman/chore/state-benchmarks-db-transaction
Jul 4, 2023
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
24891b0
state benchmark skeleton
bvrooman 7293735
setup DB using merkle tree from set
bvrooman 94baa73
tests
bvrooman 64e6775
Fix
bvrooman ddee9ec
Merge branch 'master' into bvrooman/chore/state-benchmarks
7fd2b79
multiple contract state tests
bvrooman 8c8667a
Merge branch 'bvrooman/chore/state-benchmarks' of https://github.com/…
bvrooman 150d5de
Fix toml
bvrooman a8e683d
Update state.rs
bvrooman 4560a23
Merge branch 'master' into bvrooman/chore/state-benchmarks
2281062
Clipheehee
bvrooman f48aed1
Use 8 orders of magnitude for test
bvrooman c96f4ca
Use outer and inner database transactions
bvrooman 8dcd261
Grammar
bvrooman 7c41686
Test DB and DB transactions
bvrooman 0fa68d3
Update vm_database.rs
bvrooman 26efa90
Fix cfg
bvrooman 159c20f
Remove From<DatabaseTransaction> for VmDatabase
bvrooman e654d2b
Merge branch 'master' into bvrooman/chore/state-benchmarks
00f2bdf
Merge branch 'bvrooman/chore/state-benchmarks' into bvrooman/chore/st…
0d3975a
Merge branch 'master' into bvrooman/chore/state-benchmarks-db-transac…
bvrooman 5189f1a
Merge branch 'master' into bvrooman/chore/state-benchmarks-db-transac…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, I was exploring if I could implement
From<DatabaseTransaction>
forVmDatabase
to simplify this logic. The implementation meant using the default forGeneratedConsensusFields
, but that is only available under thetest
ortest-helpers
configuration. During benchmarking, neither of this flags are automatically available, and I did not think it would be valuable to require users to add a test configuration to their benchmarking at this time.