feat: Add enable-p2p
flag to fuel-core
CLI
#1268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
fuel-core
#1236This PR disables P2P by default, and adds a new flag to the
fuel-core
CLI to allow users to expressly enable P2P:Currently, the P2P service is only enabled when the user provides CLI arguments for
keypair
andnetwork
. If either of these values are missing, P2P is implicitly disabled without warning to the user. There is no way to tell if the user accidentally omitted these values, or deliberately omitted them in order to disable P2P.A better user experience is to enable P2P explicitly using
--enable-p2p
and to makekeypair
andnetwork
mandatory. This will raise an error if either of these values is missing. P2P should be disabled by default. This flag replaces having to add or remove thenetwork
argument to enable or disable P2P implicitly.If a user wants to run
fuel-core
with P2P, and supplies--enable-p2p
, but forgets to includekeypair
and/ornetwork
, they will encounter an error: