Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small nits found during deploying and benchmarking #1303

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Small nits found during deploying and benchmarking #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad4cd4
Small nits found during deploying and benchmarking
xgreenx Aug 16, 2023
d34d3c6
Ignore audit report
xgreenx Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cargo/audit.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[advisories]
ignore = ["RUSTSEC-2022-0093"] # https://github.com/FuelLabs/fuel-core/issues/1301
2 changes: 1 addition & 1 deletion benches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Or for a dependent bench you would do:

## Using `collect` to generate bench data
Firstly you should run the benchmarks and collect the output:
`cargo criterion -p fuel-core-benches --message-format json -- --bench >bench.json`
`cargo criterion -p fuel-core-benches --message-format json --bench vm > bench.json`
You could just pipe the output into the collect binary but benches are slow to run
so I suggest saving the output like above.

Expand Down
4 changes: 2 additions & 2 deletions crates/services/sync/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ where
E: BlockImporterPort + Send + Sync + 'static,
C: ConsensusPort + Send + Sync + 'static,
{
const NAME: &'static str = "fuel-core-sync";
const NAME: &'static str = "SyncTask";

type SharedData = ();

Expand Down Expand Up @@ -195,7 +195,7 @@ where
E: BlockImporterPort + Send + Sync + 'static,
C: ConsensusPort + Send + Sync + 'static,
{
const NAME: &'static str = "fuel-core-sync/import-task";
const NAME: &'static str = "ImportTask";

type SharedData = ();
type TaskParams = ();
Expand Down
Loading