Regenesis support #1413
Regenesis support #1413
Conversation
|
The Cargo.lock file should not be deleted. It is important for binary distribution stability and ci caching. |
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub struct StateImporter<T> { |
There was a problem hiding this comment.
Would it be possible to specify what kind of state, rather than just general StateImporter? Like ChainState or whatever is most appropriate.
| } | ||
| } | ||
|
|
||
| struct InMemorySource { |
There was a problem hiding this comment.
Did you consider, instead of abstracting along the Read and Write trait, providing some domain specific trait, e.g. ChainStateSource or something along those lines?
Then instead of injecting this fake file construct, you could have an InMemoryChainStateSource and a FileSystemChainStateSource, which would allow you define these things in terms of domain specific actions instead of implementation specific actions:
read_chain_state vs read.
Interested to hear your thoughts :)
|
We've split it into several smaller PRs |
Closes #1450
Remaining tasks: