Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Enum for GQL versions (0.24.3) #1861

Merged

Conversation

bvrooman
Copy link
Contributor

@bvrooman bvrooman commented Apr 24, 2024

This branch is based off of 0.24.2 This PR is a hotfix for GQL version types and applies the change from #1856 on master to this branch.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@bvrooman bvrooman added the breaking A breaking api change label Apr 24, 2024
@bvrooman bvrooman changed the title Use Enum for GQL versions fix: Use Enum for GQL versions Apr 24, 2024
@bvrooman bvrooman changed the title fix: Use Enum for GQL versions fix: Use Enum for GQL versions (0.24.3) Apr 24, 2024
@bvrooman bvrooman marked this pull request as ready for review April 24, 2024 12:41
@bvrooman bvrooman merged commit 9e21067 into release/v0.24.3 Apr 24, 2024
49 of 65 checks passed
@bvrooman bvrooman deleted the bvrooman/fix/0.24.3/use-enum-for-gql-versions branch April 24, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants