Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TODO clippy to wait for false positive correction #2110

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Change TODO clippy to wait for false positive correction #2110

merged 6 commits into from
Aug 21, 2024

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Aug 20, 2024 •
edited by Dentosal
Loading

Closes #2100

Description

Changes the TODO clippy as it's false positive that will be fixed in the next Rust releases.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@AurelienFT AurelienFT self-assigned this Aug 20, 2024
@Dentosal Dentosal added the no changelog Skip the CI check of the changelog modification label Aug 20, 2024
@Dentosal Dentosal enabled auto-merge (squash) August 20, 2024 10:38
@AurelienFT AurelienFT requested a review from a team August 20, 2024 10:48
@Dentosal Dentosal merged commit 52d031f into master Aug 21, 2024
35 checks passed
@Dentosal Dentosal deleted the change_todo_clippy branch August 21, 2024 09:07
@xgreenx xgreenx mentioned this pull request Aug 28, 2024
Merged
xgreenx added a commit that referenced this pull request Aug 28, 2024
@xgreenx
Release v0.35.0 (#2136)
9f96573 
## Version v0.35.0

### Added
- [2122](#2122): Changed the
relayer URI address to be a vector and use a quorum provider. The
`relayer` argument now supports multiple URLs to fetch information from
different sources.
- [2119](#2119): GraphQL query
fields for retrieving information about upgrades.

### Changed
- [2113](#2113): Modify the
way the gas price service and shared algo is initialized to have some
default value based on best guess instead of `None`, and initialize
service before graphql.
- [2112](#2112): Alter the way
the sealed blocks are fetched with a given height.
- [2120](#2120): Added
`submitAndAwaitStatus` subscription endpoint which returns the
`SubmittedStatus` after the transaction is submitted as well as the
`TransactionStatus` subscription.
- [2115](#2115): Add test for
`SignMode` `is_available` method.
- [2124](#2124): Generalize
the way p2p req/res protocol handles requests.

#### Breaking

- [2040](#2040): Added full
`no_std` support state transition related crates. The crates now require
the "alloc" feature to be enabled. Following crates are affected:
  - `fuel-core-types`
  - `fuel-core-storage`
  - `fuel-core-executor`
- [2116](#2116): Replace
`H160` in config and cli options of relayer by `Bytes20` of `fuel-types`

### Fixed
- [2134](#2134): Perform
RecoveryID normalization for AWS KMS -generated signatures.

## What's Changed
* Change TODO clippy to wait for false positive correction by
@AurelienFT in #2110
* Remove option on shared algo, give default algo, reorder service
startup by @MitchTurner in
#2113
* chore(sealed_blocks): optimize fetching of sealed block header at a
given height by @rymnc in
#2112
* chore(p2p_service): remove unnecessary cast to usize by @rymnc in
#2123
* Added a benchmark for the predicate with ed19 verification by @xgreenx
in #2127
* Add test SignMode is_available by @AurelienFT in
#2115
* feat: Add graphql query fields for retreiving information about
upgrades by @netrome in #2119
* Small code optimizations by @MoneyBund in
#2035
* Change relayer URI address to be vector and use quorum provider by
@AurelienFT in #2122
* chore(p2p_service): clean up processing of p2p req/res protocol by
@rymnc in #2124
* feat: add `submitAndAwaitStatus` subscription endpoint by @maschad in
#2120
* Replace H160 in config and cli options of relayer by Bytes20 by
@AurelienFT in #2116
* Secp256k1 RecoveryID correction for KMS-genrated signatures by
@Dentosal in #2134
* Added `no_std` support state transition related crates by @xgreenx in
#2040

## New Contributors
* @MoneyBund made their first contribution in
#2035
* @maschad made their first contribution in
#2120

**Full Changelog**:
v0.34.0...v0.35.0
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this pull request Sep 7, 2024
@GoldenPath1109 @rymnc
Release v0.35.0 (#2136)
63f8bd1 
## Version v0.35.0

### Added
- [2122](FuelLabs/fuel-core#2122): Changed the
relayer URI address to be a vector and use a quorum provider. The
`relayer` argument now supports multiple URLs to fetch information from
different sources.
- [2119](FuelLabs/fuel-core#2119): GraphQL query
fields for retrieving information about upgrades.

### Changed
- [2113](FuelLabs/fuel-core#2113): Modify the
way the gas price service and shared algo is initialized to have some
default value based on best guess instead of `None`, and initialize
service before graphql.
- [2112](FuelLabs/fuel-core#2112): Alter the way
the sealed blocks are fetched with a given height.
- [2120](FuelLabs/fuel-core#2120): Added
`submitAndAwaitStatus` subscription endpoint which returns the
`SubmittedStatus` after the transaction is submitted as well as the
`TransactionStatus` subscription.
- [2115](FuelLabs/fuel-core#2115): Add test for
`SignMode` `is_available` method.
- [2124](FuelLabs/fuel-core#2124): Generalize
the way p2p req/res protocol handles requests.

#### Breaking

- [2040](FuelLabs/fuel-core#2040): Added full
`no_std` support state transition related crates. The crates now require
the "alloc" feature to be enabled. Following crates are affected:
  - `fuel-core-types`
  - `fuel-core-storage`
  - `fuel-core-executor`
- [2116](FuelLabs/fuel-core#2116): Replace
`H160` in config and cli options of relayer by `Bytes20` of `fuel-types`

### Fixed
- [2134](FuelLabs/fuel-core#2134): Perform
RecoveryID normalization for AWS KMS -generated signatures.

## What's Changed
* Change TODO clippy to wait for false positive correction by
@AurelienFT in FuelLabs/fuel-core#2110
* Remove option on shared algo, give default algo, reorder service
startup by @MitchTurner in
FuelLabs/fuel-core#2113
* chore(sealed_blocks): optimize fetching of sealed block header at a
given height by @rymnc in
FuelLabs/fuel-core#2112
* chore(p2p_service): remove unnecessary cast to usize by @rymnc in
FuelLabs/fuel-core#2123
* Added a benchmark for the predicate with ed19 verification by @xgreenx
in FuelLabs/fuel-core#2127
* Add test SignMode is_available by @AurelienFT in
FuelLabs/fuel-core#2115
* feat: Add graphql query fields for retreiving information about
upgrades by @netrome in FuelLabs/fuel-core#2119
* Small code optimizations by @MoneyBund in
FuelLabs/fuel-core#2035
* Change relayer URI address to be vector and use quorum provider by
@AurelienFT in FuelLabs/fuel-core#2122
* chore(p2p_service): clean up processing of p2p req/res protocol by
@rymnc in FuelLabs/fuel-core#2124
* feat: add `submitAndAwaitStatus` subscription endpoint by @maschad in
FuelLabs/fuel-core#2120
* Replace H160 in config and cli options of relayer by Bytes20 by
@AurelienFT in FuelLabs/fuel-core#2116
* Secp256k1 RecoveryID correction for KMS-genrated signatures by
@Dentosal in FuelLabs/fuel-core#2134
* Added `no_std` support state transition related crates by @xgreenx in
FuelLabs/fuel-core#2040

## New Contributors
* @MoneyBund made their first contribution in
FuelLabs/fuel-core#2035
* @maschad made their first contribution in
FuelLabs/fuel-core#2120

**Full Changelog**:
FuelLabs/fuel-core@v0.34.0...v0.35.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dentosal Dentosal Dentosal approved these changes

@xgreenx xgreenx xgreenx approved these changes

Assignees

@AurelienFT AurelienFT

Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup #[allow(clippy::assigning_clones)]
3 participants
@AurelienFT @Dentosal @xgreenx