PanicReason rework #477
Merged
PanicReason rework #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
breaking
…for the `PanicReason`. Updated CHANGELOG.md
xgreenx
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
PanicReasonto automatically derive conversion traits, removing the need for manual bookkeeping of error numbers. This also removes some of the unused error variants. The unutilizedInvalidPanicReasonerror is removed as well, and merged intoUnknownPanicReasonvariant.This PR is in preparation for adding more granular
PanicReasonvariants.Originally from #461, and extracted here for a separate review.
Alternatives
Instead of removing unused errors and reordering the rest, the same numeric values could be kept. However, nobody should be depending on the numeric values, which I consider to be strictly an implementation detail of the VM.