Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: BMT clean up #492

Merged
merged 9 commits into from
Jun 14, 2023
Merged

chore: BMT clean up #492

merged 9 commits into from
Jun 14, 2023

Conversation

bvrooman
Copy link
Contributor

@bvrooman bvrooman commented Jun 13, 2023 •
edited
Loading

This PR adds small improvements to the BMT:

  • simplifies the build_root_node method
  • simplifies the join_all_subtrees method and adds comments
  • removes Box from the BMT implementation and Subtree interface

@bvrooman bvrooman marked this pull request as ready for review June 13, 2023 20:37
@bvrooman bvrooman requested a review from a team June 13, 2023 20:37
@bvrooman bvrooman self-assigned this Jun 13, 2023
@bvrooman bvrooman added this pull request to the merge queue Jun 14, 2023
Merged via the queue into master with commit 26f13f0 Jun 14, 2023
@bvrooman bvrooman deleted the bvrooman/chore/bmt-clean-up branch June 14, 2023 16:44
@xgreenx xgreenx mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

Assignees

@bvrooman bvrooman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvrooman @xgreenx