Support of the multi-assets per contract #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new `Mint` and `Burn` receipts with serialization nand deserialization. - `mint` and `burn` opcodes accept a new `$rB` register - `sub_id` - `mint` and `burn` opcodes produces receipts now.
Voxelot
reviewed
Jul 12, 2023
| ReceiptRepr::Mint as u8, | ||
| ); | ||
|
|
||
| bytes::store_at(buf, S::layout(S::LAYOUT.sub_id), sub_id); |
There was a problem hiding this comment.
Why do we put sub id before contract id?
There was a problem hiding this comment.
It is layout from the specification=)
Voxelot
reviewed
Jul 12, 2023
| pub(crate) fn mint(&mut self, a: Word, b: Word) -> Result<(), RuntimeError> { | ||
| let (SystemRegisters { fp, pc, is, .. }, _) = | ||
| split_registers(&mut self.registers); | ||
| MindCtx { |
Voxelot
approved these changes
Jul 13, 2023
bvrooman
reviewed
Jul 13, 2023
| /// Trait extends the functionality of the `ContractId` type. | ||
| pub trait ContractIdExt { | ||
| /// Creates an `AssetId` from the `ContractId` and `sub_id`. | ||
| fn asset_id(&self, sub_id: &Bytes32) -> AssetId; |
There was a problem hiding this comment.
Is it worth reusing AssetID here for sub_id, or maybe creating a type/type alias for SubId?
bvrooman
approved these changes
Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #496
MintandBurnreceipts with serialization and deserialization.mintandburnopcodes accept a new$rBregister -sub_idmintandburnopcodes produce receipts now.