Initializing WASM synchronously #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arboleya
force-pushed
the
aa/fix/initializing-wasm-synchronously
branch
from
4316b88
to
b2643b8
Compare
arboleya
force-pushed
the
aa/fix/initializing-wasm-synchronously
branch
from
b2643b8
to
c765752
Compare
xgreenx
approved these changes
Jul 26, 2023
|
Can we publish this to npm? |
|
Actually if I read this correctly (link from description: https://github.com/rollup/plugins/tree/master/packages/wasm/#synchronous-modules)
I've never seen a wasm file this small in the wild, and the ones generated for asm here are 270k when I look at the file locally. |
|
I saw that warning but went with it since everything worked consistently on my tests. As you suggested, I will run more in-depth tests at the file level and report back here. If we have to force async initialization, we'll need something like: asm.init().then(() => asm.movi(...))@xgreenx Please hold the release a bit more, so I can get to the bottom of this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the WASM binary is initialized synchronously so that it is available right after being imported.