Add a single stepping example #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
approved these changes
May 2, 2024
MitchTurner
reviewed
May 2, 2024
| } | ||
| ProgramState::VerifyPredicate(d) => { | ||
| println!("paused on debugger {d:?} (in predicate)"); | ||
| t = vm.resume().expect("panicked"); |
There was a problem hiding this comment.
Nit: I feel like we should be using unwrap in all these places that call expect. expect is meant to explain why it's expected to be Ok. In all these cases we just say that it's failing.
There was a problem hiding this comment.
This is an example, so I'm using expect to highlight that in real-world usage you're supposed to handle the errors.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small example to demonstrate single-stepping to show execution trace.
Before requesting review