Add misc tests #751
Merged
Add misc tests #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Jun 5, 2024
Comment on lines
+83
to
+87
| op::addi(0x10, RegId::ZERO, 8), | ||
| op::addi(0x11, RegId::ZERO, 16), | ||
| op::addi(0x12, RegId::ZERO, 32), | ||
| op::addi(0x13, RegId::ZERO, 64), | ||
| op::addi(0x14, RegId::ZERO, 128), |
There was a problem hiding this comment.
It would be nice to use some constant names for registers. It will connect them here with the values in suite
Comment on lines
+172
to
+185
| let consensus_params = ConsensusParameters::standard(); | ||
|
|
||
| let tx = TransactionBuilder::script(script, vec![]) | ||
| .script_gas_limit(gas_limit) | ||
| .add_random_fee_input() | ||
| .finalize() | ||
| .into_checked(height, &consensus_params) | ||
| .expect("failed to generate checked tx") | ||
| .into_ready( | ||
| gas_price, | ||
| consensus_params.gas_costs(), | ||
| consensus_params.fee_params(), | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
It seems we repeat this part several times, maybe makes sense to move it into a function
xgreenx
approved these changes
Jun 5, 2024
|
Merging this as-is, those nits will be addressed later when we'll expand the test helper context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves test coverage by testing some code paths that were not previously take. Will not contain any externally visible changes, only adding more tests and cleaning up existing ones.
Before requesting review