Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid conversion into usize type and use u32 or u64 instead #789

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Avoid conversion into usize type and use u32 or u64 instead #789

merged 4 commits into from
Jul 4, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jul 4, 2024

  • Removed try_into conversion into usize.
  • Updated CallFrame to store only padded code size.

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx requested review from Dentosal and a team July 4, 2024 19:04
@xgreenx xgreenx self-assigned this Jul 4, 2024
@xgreenx xgreenx enabled auto-merge July 4, 2024 19:16
@xgreenx xgreenx added this pull request to the merge queue Jul 4, 2024
Merged via the queue into master with commit a6abe47 Jul 4, 2024
38 of 39 checks passed
@xgreenx xgreenx deleted the bugfix/32-bit-different-results branch July 4, 2024 20:10
This was referenced Jul 4, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dentosal Dentosal Dentosal approved these changes

Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xgreenx @Dentosal