Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade fuel-core to 0.24.3 #2021

Merged
merged 541 commits into from
Apr 25, 2024
Merged

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Apr 6, 2024

Breaking Changes

  • Requires Forc 0.51.1
  • Setting maxFee is always required now ( The SDK estimates it by default with Provider.getTransactionCost + Account.fund )
  • gasPrice is calculated by the VM so we do not need to inform it anymore. The Policy gasPrice was replaced by tip
  • Account.fund signature has changed
  • Graphql URL now includes a versioning path: http://127.0.0.1:4000/v1/graphql
  • calculateTransactionFee now requires tip, maxGasPerTx, and gasPrice
  • calculateTransactionFee does not receive gasUsed anymore
  • removed unneeded properties returned by Provider.getTransactionCost

Current Tests Passing:
Screenshot 2024-04-08 at 10 38 54

@Torres-ssf Torres-ssf added chore Issue is a chore mainnet labels Apr 6, 2024
@Torres-ssf Torres-ssf self-assigned this Apr 6, 2024
@Torres-ssf Torres-ssf changed the base branch from st/chore/update-dry-run-mutation to master April 8, 2024 13:27
@fuel-service-user
Copy link
Contributor

fuel-service-user commented Apr 8, 2024

✨ A PR has been created under the rc-2021 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1215

Base automatically changed from db/feat/dynamic-base-asset to master April 25, 2024 18:22
@arboleya arboleya self-requested a review April 25, 2024 18:35
arboleya
arboleya previously approved these changes Apr 25, 2024
arboleya
arboleya previously approved these changes Apr 25, 2024
@Torres-ssf Torres-ssf enabled auto-merge (squash) April 25, 2024 18:53
@arboleya arboleya disabled auto-merge April 25, 2024 18:58
@arboleya arboleya self-requested a review April 25, 2024 21:11
@Torres-ssf Torres-ssf enabled auto-merge (squash) April 25, 2024 21:21
@Torres-ssf Torres-ssf merged commit 9c3c094 into master Apr 25, 2024
16 of 17 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/upgrade-fuel-core-0.24.1 branch April 25, 2024 21:27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is appears to be the related file changes that are causing the following issue (#2242).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here he comes. 🕵️‍♂️ 🚨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fuel-core to 0.24.3 Fetch latest gas price from fuel-core node Support new dry_run interface
9 participants