Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment tests for expr in sfv2 #2497

Closed
Tracked by #2494
eureka-cpu opened this issue Aug 9, 2022 · 2 comments
Closed
Tracked by #2494

Add comment tests for expr in sfv2 #2497

eureka-cpu opened this issue Aug 9, 2022 · 2 comments
Labels
forc formatter good first issue Good for newcomers testing General testing
Milestone
swayfmt

Comments

@eureka-cpu
Copy link
Contributor

Currently we are supporting this kind of comments as long as it is parsed.

Example

// This can be parsed and supported

let number: /* this number is for counting */ u64 = 10;

// This cannot be parsed and not supported
let number: // this number is for counting u64 = 10;
@eureka-cpu eureka-cpu added good first issue Good for newcomers forc testing General testing formatter labels Aug 9, 2022
@eureka-cpu eureka-cpu added this to the swayfmt-v2 milestone Aug 9, 2022
@eureka-cpu eureka-cpu mentioned this issue Aug 9, 2022
Merged
21 tasks
@eureka-cpu eureka-cpu mentioned this issue Oct 1, 2022
Open
17 tasks
@cr-fuel cr-fuel self-assigned this Sep 19, 2023
@eureka-cpu
Copy link
Contributor Author

This may no longer be an issue, especially since there are new changes that should be preventing the formatter from panicking. Will need triaging.

@JoshuaBatty JoshuaBatty assigned eureka-cpu and unassigned cr-fuel Sep 29, 2023
@eureka-cpu eureka-cpu removed their assignment Nov 1, 2023
@cr-fuel cr-fuel self-assigned this Nov 6, 2023
@crodas crodas assigned crodas and unassigned cr-fuel Dec 1, 2023
crodas added a commit that referenced this issue Dec 5, 2023
@crodas
Improve comments in-between doc-comments and functions/methods
a04f860 
This was discovered while adding tests for #2790, #2497. This is a
regression from #4185
@crodas crodas mentioned this issue Dec 5, 2023
Merged
7 tasks
crodas added a commit that referenced this issue Dec 5, 2023
@crodas
Improve comments in-between doc-comments and functions/methods
54aa1fa 
This was discovered while adding tests for #2790, #2497. This is a
regression from #4185
crodas added a commit that referenced this issue Dec 5, 2023
@crodas
Improve comments in-between doc-comments and functions/methods
5c9c734 
This was discovered while adding tests for #2790, #2497. This is a
regression from #4185
crodas added a commit that referenced this issue Dec 5, 2023
@crodas
Improve comments in-between doc-comments and functions/methods
bdea31c 
This was discovered while adding tests for #2790, #2497. This is a
regression from #4185
crodas added a commit that referenced this issue Dec 5, 2023
@crodas
Improve comments in-between doc-comments and functions/methods (#5364)
f851440 
## Description

This was discovered while adding tests for #2790, #2497. This is a
regression from #4185

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
@crodas crodas removed their assignment Apr 17, 2024
@JoshuaBatty
Copy link
Member

added in #5364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forc formatter good first issue Good for newcomers testing General testing
Projects
None yet
Milestone
swayfmt
Development

No branches or pull requests
4 participants
@crodas @JoshuaBatty @eureka-cpu @cr-fuel