-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chained methods & fields that should be multiline need logic to handle vertical formatting #3474
Comments
hey @eureka-cpu, is the issue still open, i'd like to try to solve this issue :)) |
Please, feel free! |
Take a look at how we handle import statements for some general direction |
Hey @eureka-cpu, sorry for such a late response but i'm not able to find the issue? Could you please help me out? |
Hi @AliJafriETH, I would start by adding a few tests to |
Hey @eureka-cpu, thank you so much for the help, I'll update you with the progress :)) Thanks 💯 |
Fixes #3474 ## Description Breaks long expressions (focusing into chained methods calls but will cover all expressions) into multiple lines ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
should be:
To elaborate further, this applies only to
swayfmt
. Logic needs to be added to handle the formatting of Sway code so that chained methods & fields that exceed a certain length (IIRC it's 60 but we are using therustfmt
standard which you can find here) are formatted as multiline chains.rustfmt
has a file dedicated to handling formatting of chains, here.The text was updated successfully, but these errors were encountered: