Adds multiline formatting for array

[eureka-cpu]

Closes #726
Ref #2493

[Braqzen]

1. How come a tuple is being tested in an array PR?
2. Should there be another test for

[ some, args, here, ...,
and, more,
here ]

and a few variations of that?

[eureka-cpu]

1. How come a tuple is being tested in an array PR?

   2. Should there be another test for

[ some, args, here, ...,
and, more,
here ]

and a few variations of that?

I can add it in another PR, they're both collections and use generally the same logic so I added it while testing to be sure they both functioned

[eureka-cpu]

@Braqzen I'm not sure I understand the second part, if you'd like I can add an explicit example though! Currently we have either normal formatting

[some, thing, here, ...]

and once it reaches a threshold it gets vertical formatting

[
    some,
    thing,
    here,
    ...,
]

[Braqzen]

@Braqzen I'm not sure I understand the second part, if you'd like I can add an explicit example though! Currently we have either normal formatting

[some, thing, here, ...]

and once it reaches a threshold it gets vertical formatting

[
    some,
    thing,
    here,
    ...,
]

What will the formatter do if it is presented with the input that I have added in the code block?
What would it do if instead of having the ] on the same line, as in my example, it would be on a new line?

[eureka-cpu]

@Braqzen I'm not sure I understand the second part, if you'd like I can add an explicit example though! Currently we have either normal formatting

[some, thing, here, ...]

and once it reaches a threshold it gets vertical formatting

[
    some,
    thing,
    here,
    ...,
]

What will the formatter do if it is presented with the input that I have added in the code block? What would it do if instead of having the ] on the same line, as in my example, it would be on a new line?

So, since this is an AST based formatter, it takes the actual items into account but not the white space. You can think of it like this, your example:

[ some, args, here, ...,
and, more,
here ]

gets collected, which you could represent like:
(keep in mind, I'm not sure how this actually looks, this is a rough representation for the purpose of explaining)

[Collection(Var("some"), Var("args"), Var("here"), Var("..."), Var("and"), Var("more"), Var("here"))]

it does not take into account any whitespace, the formatter strips that by design and we inject whitespace and newlines situationally
So the output would look like:

[some, args, here, ..., and, more, here]

[Braqzen]

@Braqzen I'm not sure I understand the second part, if you'd like I can add an explicit example though! Currently we have either normal formatting

[some, thing, here, ...]

and once it reaches a threshold it gets vertical formatting

[
    some,
    thing,
    here,
    ...,
]

What will the formatter do if it is presented with the input that I have added in the code block? What would it do if instead of having the ] on the same line, as in my example, it would be on a new line?

So, since this is an AST based formatter, it takes the actual items into account but not the white space. You can think of it like this, your example:

[ some, args, here, ...,
and, more,
here ]

gets collected, which you could represent like: (keep in mind, I'm not sure how this actually looks, this is a rough representation for the purpose of explaining)

[Collection(Var("some"), Var("args"), Var("here"), Var("..."), Var("and"), Var("more"), Var("here"))]

it does not take into account any whitespace, the formatter strips that by design and we inject whitespace and newlines situationally So the output would look like:

[some, args, here, ..., and, more, here]

That sounds really cool. Thanks for letting me know!