Refactor: Split use synonyms into separate maps for glob and item imports #5914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5911 .
So far all imported items in a module have been collected in single map, with a flag in each value indicating whether it was the result of a glob/star import or an item import (this distinction matters because item imports shadow glob imports).
This PR splits the map in two: One for glob imports and one for item imports. This simplifies name resolution, and eliminates the
GlobImport
flag.When another module imports all reexported items the logic is now slightly more complex, but this will be resolved once the excessive cloning of namespaces, modules and typed declarations are eliminated.
Checklist
Breaking*
orNew Feature
labels where relevant.