Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔍add unique page descriptions #404

Merged
merged 1 commit into from
Sep 24, 2023
Merged

🔍add unique page descriptions #404

merged 1 commit into from
Sep 24, 2023

Conversation

lFourl
Copy link
Contributor

@lFourl lFourl commented Sep 23, 2023

Closes #356

Changelog

✨ Additions

  • add unique page descriptions

⚡ Changes

🔥 Removals

🐛 Fixes

⚙ Tasks

Additional Information

Contributor's Checklist

  • This PR was created to resolve an existing issue or set of issues.
  • This PR satisfies any and all acceptance criteria laid out by issue(s) it resolves.
  • I have discussed creating this PR with the maintainers in the issue(s) beforehand.
  • I have thoroughly tested the changes this PR introduces in a local development environment.
  • I have linted the entire codebase using yarn lint and confirmed there are no errors or warnings.
  • I have followed the commit conventions laid out by CONTRIBUTING.md.

Maintainer's Checklist

  • User-facing changes this PR introduces has been or will be documented in CHANGELOG.md.
  • This PR has been linted and tested locally as a part of the review process.
  • All issues this PR resolves have been properly linked before merging.

Copy link
Member

@UncleClapton UncleClapton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @lFourl, Thanks for the descriptions!

I got your message over IRC, but I haven't been able to catch you to respond. I'm glad you put this in as a PR, as that would have been my suggestion to review the descriptions. They look great!

@UncleClapton
Copy link
Member

@all-contributors please add @lFourl for code and content

@allcontributors
Copy link
Contributor

@UncleClapton

I've put up a pull request to add @lFourl! 🎉

@UncleClapton UncleClapton merged commit 4816880 into FuelRats:develop Sep 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unique page descriptions for each page
2 participants