fix policies + remaining PHPDoc errors

api/app/Console/Commands/CheckIntl.php

@@ -3,7 +3,6 @@
 namespace App\Console\Commands;
 
 use App\Discoverers\EnumDiscoverer;
-use App\Traits\HasLocalization;
 use Illuminate\Console\Command;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Facades\Lang;
@@ -79,7 +78,6 @@ public function handle()
     {
         $this->localizedEnums = EnumDiscoverer::discoverLocalizedEnums();
 
-        /** @var HasLocalization $enum */
         foreach ($this->localizedEnums as $enum) {
             $this->checkStrings($enum);
         }

api/app/Policies/ClassificationPolicy.php

@@ -26,7 +26,6 @@ public function viewAny(?User $user)
      *
      * Note: This action is possible for everyone, including anonymous users
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function view(?User $user)
@@ -47,7 +46,6 @@ public function create(User $user)
     /**
      * Determine whether the user can update the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function update(User $user)
@@ -58,7 +56,6 @@ public function update(User $user)
     /**
      * Determine whether the user can delete the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function delete(User $user)
@@ -69,7 +66,6 @@ public function delete(User $user)
     /**
      * Determine whether the user can restore the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function restore(User $user)
@@ -80,7 +76,6 @@ public function restore(User $user)
     /**
      * Determine whether the user can permanently delete the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function forceDelete(User $user)

api/app/Policies/CommunityPolicy.php

@@ -44,7 +44,6 @@ public function create(User $user)
     /**
      * Determine whether the user can update models.
      *
-     * @param  \App\Models\Community|null  $community
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function update(User $user, Community $community)
@@ -55,7 +54,6 @@ public function update(User $user, Community $community)
     /**
      * Determine whether the user can view the team members of a specific communities team
      *
-     * @param  \App\Models\Community|null  $community
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function viewTeamMembers(User $user, Community $community)

api/app/Policies/DepartmentPolicy.php

@@ -26,7 +26,6 @@ public function viewAny(?User $user)
      *
      * Note: This action is possible for everyone, including anonymous users
      *
-     * @param  \App\Models\Department  $department
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function view(?User $user)
@@ -47,7 +46,6 @@ public function create(User $user)
     /**
      * Determine whether the user can update the model.
      *
-     * @param  \App\Models\Department  $department
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function update(User $user)
@@ -58,7 +56,6 @@ public function update(User $user)
     /**
      * Determine whether the user can delete the model.
      *
-     * @param  \App\Models\Department  $department
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function delete(User $user)
@@ -69,7 +66,6 @@ public function delete(User $user)
     /**
      * Determine whether the user can restore the model.
      *
-     * @param  \App\Models\Department  $department
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function restore(User $user)
@@ -80,7 +76,6 @@ public function restore(User $user)
     /**
      * Determine whether the user can permanently delete the model.
      *
-     * @param  \App\Models\Department  $department
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function forceDelete(User $user)

api/app/Policies/GenericJobTitlePolicy.php

@@ -26,7 +26,6 @@ public function viewAny(?User $user)
      *
      * Note: This action is possible for everyone, including anonymous users
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function view(?User $user)
@@ -47,7 +46,6 @@ public function create(User $user)
     /**
      * Determine whether the user can update the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function update(User $user)
@@ -58,7 +56,6 @@ public function update(User $user)
     /**
      * Determine whether the user can delete the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function delete(User $user)
@@ -69,7 +66,6 @@ public function delete(User $user)
     /**
      * Determine whether the user can restore the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function restore(User $user)
@@ -80,7 +76,6 @@ public function restore(User $user)
     /**
      * Determine whether the user can permanently delete the model.
      *
-     * @param  \App\Models\Classification  $classification
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function forceDelete(User $user)

api/app/Policies/PoolCandidatePolicy.php

@@ -144,7 +144,6 @@ public function suspend(User $user, PoolCandidate $poolCandidate)
      * Note: Everyone needs to be able to count applicants
      * for now
      *
-     * @param  \App\Models\PoolCandidate  $poolCandidate
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function count()

api/app/Policies/RolePolicy.php

@@ -13,7 +13,6 @@ class RolePolicy
     /**
      * Determine whether the user can view any models.
      *
-     * @param  \App\Models\User|null  $user
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function viewAny(User $user)
@@ -35,8 +34,6 @@ public function viewAnyRoleAssignments(User $user)
     /**
      * Determine whether the user can view a specific role
      *
-     * @param  \App\Models\User|null  $user
-     * @param  \App\Models\Role|null  $role
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function view(User $user)
@@ -47,8 +44,6 @@ public function view(User $user)
     /**
      * Determine whether the user can update a specific role
      *
-     * @param  \App\Models\User|null  $user
-     * @param  \App\Models\Role|null  $role
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function update(User $user)

api/app/Policies/SkillFamilyPolicy.php

@@ -26,7 +26,6 @@ public function viewAny(?User $user)
      *
      * Note: This action is possible for everyone, including anonymous users
      *
-     * @param  \App\Models\SkillFamily  $skillFamily
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function view(?User $user)
@@ -47,7 +46,6 @@ public function create(User $user)
     /**
      * Determine whether the user can update the model.
      *
-     * @param  \App\Models\SkillFamily  $skillFamily
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function update(User $user)
@@ -58,7 +56,6 @@ public function update(User $user)
     /**
      * Determine whether the user can delete the model.
      *
-     * @param  \App\Models\SkillFamily  $skillFamily
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function delete(User $user)
@@ -69,7 +66,6 @@ public function delete(User $user)
     /**
      * Determine whether the user can restore the model.
      *
-     * @param  \App\Models\SkillFamily  $skillFamily
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function restore(User $user)
@@ -80,7 +76,6 @@ public function restore(User $user)
     /**
      * Determine whether the user can permanently delete the model.
      *
-     * @param  \App\Models\SkillFamily  $skillFamily
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function forceDelete(User $user)

api/app/Policies/SkillPolicy.php

@@ -26,7 +26,6 @@ public function viewAny(?User $user)
      *
      * Note: This action is possible for everyone, including anonymous users
      *
-     * @param  \App\Models\Skill  $skill
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function view(?User $user)
@@ -47,7 +46,6 @@ public function create(User $user)
     /**
      * Determine whether the user can update the model.
      *
-     * @param  \App\Models\Skill  $skill
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function update(User $user)
@@ -58,7 +56,6 @@ public function update(User $user)
     /**
      * Determine whether the user can delete the model.
      *
-     * @param  \App\Models\Skill  $skill
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function delete(User $user)
@@ -69,7 +66,6 @@ public function delete(User $user)
     /**
      * Determine whether the user can restore the model.
      *
-     * @param  \App\Models\Skill  $skill
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function restore(User $user)
@@ -80,7 +76,6 @@ public function restore(User $user)
     /**
      * Determine whether the user can permanently delete the model.
      *
-     * @param  \App\Models\Skill  $skill
      * @return \Illuminate\Auth\Access\Response|bool
      */
     public function forceDelete(User $user)

api/app/Policies/TeamPolicy.php

@@ -67,10 +67,9 @@ public function delete(User $user)
     /**
      * Determine whether the user can view a specific teams, team members.
      *
-     * @param  \App\Models\Team/null $team
      * @return \Illuminate\Auth\Access\Response|bool
      */
-    public function viewTeamMembers(User $user, Team $team)
+    public function viewTeamMembers(User $user, ?Team $team)
     {
         return $user->isAbleTo('view-any-teamMembers') || $user->isAbleTo('view-team-teamMembers', $team);
     }

api/app/Providers/GraphQLServiceProvider.php

@@ -53,8 +53,6 @@ static function () use ($name, $enum): EnumType {
 
         /** Discover all enums in the App\Enum namespace that implement the HasLocalization trait
          * and register them as a LocalizedEnum type in GraphQL
-         *
-         * @var array<HasLocalization>
          */
         $localizedEnums = EnumDiscoverer::discoverLocalizedEnums();
 
@@ -65,6 +63,7 @@ static function () use ($name, $enum): EnumType {
             $resolver = function ($value, $args, $context, ResolveInfo $info) use ($enum) {
                 switch ($info->fieldName) {
                     case 'value': return $value;
+                        /** @disregard P1013 Can't type hint traits */
                     case 'label': return $enum::localizedString($value);
                     default: return null;
                 }

api/app/Providers/RouteServiceProvider.php

@@ -19,15 +19,6 @@ class RouteServiceProvider extends ServiceProvider
      */
     public const HOME = '/home';
 
-    /**
-     * The controller namespace for the application.
-     *
-     * When present, controller route declarations will automatically be prefixed with this namespace.
-     *
-     * @var string|null
-     */
-    // protected $namespace = 'App\\Http\\Controllers';
-
     /**
      * Define your route model bindings, pattern filters, etc.
      *