Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add middle content to accordion component #11587

Open
2 tasks
petertgiles opened this issue Sep 23, 2024 · 1 comment · May be fixed by #11674
Open
2 tasks

✨ Add middle content to accordion component #11587

petertgiles opened this issue Sep 23, 2024 · 1 comment · May be fixed by #11674
Assignees
Labels
feature New feature or request.

Comments

@petertgiles
Copy link
Contributor

petertgiles commented Sep 23, 2024

✨ Feature

On the manager dashboard we need an accordion that has some space for interactive content between the trigger and the content. Currently, the content is manually added on that page but the spacing is not configurable enough.

🎨 Design

Josh:

Component specification:
https://www.figma.com/design/guHeIIh8dqFVCks310Wv0G/Component-library?node-id=5-20&node-type=canvas&t=3VSWIj96B8VFWC0D-0

Accordion that needs middle content:
https://www.figma.com/design/oZhQe9ahidHFfaiqgREvxa/Dashboard-(All-users)?node-id=1010-18680&t=jCsiShy545bh9AqT-4

📸 Screenshot

image

🙋‍♀️ Proposed Implementation

From Josh:
It would be nice to build this into the component so we can reuse it elsewhere... a slot or something you can pass 0 or more actions to or something similar.

Should accept an array of items, like the preview list item.

✅ Acceptance Criteria

  • Component updated
  • Manager dashboard accordion updated to use new component feature

🛑 Blockers

Blocked By

No tasks being tracked yet.
@petertgiles petertgiles added feature New feature or request. blocked: design Blocked by missing designs. labels Sep 23, 2024
@petertgiles
Copy link
Contributor Author

petertgiles commented Sep 23, 2024

@JoshBeveridge Could you please update the component specification in Figma to show how this should be implemented?

Will the component accept any kind of content in the middle? Or just an array of links?

@petertgiles petertgiles added this to the Manager accounts milestone Sep 23, 2024
@yonikid15 yonikid15 added blocked: design Blocked by missing designs. and removed blocked: design Blocked by missing designs. labels Sep 24, 2024
@petertgiles petertgiles removed the blocked: design Blocked by missing designs. label Sep 25, 2024
@yonikid15 yonikid15 self-assigned this Sep 26, 2024
@yonikid15 yonikid15 linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request.
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

2 participants