[Feature] Accordion middle partials #11674
Conversation
It looks like the name that Josh uses in Figma is "Metadata". I think it's a good idea to stay in sync with designers for names so I'd suggest just correcting the capitalization. |
| @@ -17,6 +18,38 @@ const Text = () => { | |||
| return <p>{faker.lorem.sentences(5)}</p>; | |||
| }; | |||
|
|
|||
| export const metaData: AccordionMetaData[] = [ | |||
There was a problem hiding this comment.
It seems like Storybook is picking this up as a story and failing to render anything.
There was a problem hiding this comment.
Uh oh, something went wrong here.
There was a problem hiding this comment.
Maybe related to switching the padding to margin?
There was a problem hiding this comment.
Nice catch! Fixed in 4148e2b
There was a problem hiding this comment.
Pre-existing, but this doesn't look right, to me.
There was a problem hiding this comment.
Hmm, ya that should be fixed. However, I believe the text was added as a reminder of the context of the icon. Normally, it would just be the icon if used across the site.
EDIT: Actually I might be wrong 😅. I'll make a new issue for this since I'm not sure what a proper fix would look like.
There was a problem hiding this comment.
Created an issue for this #11700
It's merged now. |
🤖 Resolves #11587
👋 Introduction
🕵️ Details
🧪 Testing
📸 Screenshot