Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update manager dashboard UI #11667

Merged
merged 13 commits into from
Oct 3, 2024
Merged

Conversation

petertgiles
Copy link
Contributor

πŸ€– Resolves #11575

πŸ‘‹ Introduction

This branch corrects (almost) all the items from Josh's design review of the manager dashboard page.

πŸ•΅οΈ Details

Note that one AC was not done:

The final item in the request accordion shouldn't have bottom padding, as the card already provides it

I think it's already correct:
image

πŸ§ͺ Testing

  1. Uncomment the loader in router.tsx to enable the manager dashboard page
  2. Visit /en/manager/dashboard

@petertgiles petertgiles marked this pull request as ready for review September 27, 2024 18:18
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! πŸ‘

I found one thing: The preview list padding on the bottom is still larger than it needs to be (x1). Dropping it to x.5 should keep it balanced with the accordion heading at the top.
image

@petertgiles
Copy link
Contributor Author

Ah, that was the last one, thanks!
The final item in the request accordion shouldn't have bottom padding…

@petertgiles
Copy link
Contributor Author

Looks like x0.25 is what Josh was looking for.
image

@petertgiles
Copy link
Contributor Author

Shoot, looks like that last change broke a bunch of stuff in the Chromatic diff. I'll have to take another look at it.

@petertgiles
Copy link
Contributor Author

@yonikid15 OK, I think I have a solution:
reduce accordion bottom padding

To be honest, I don't love it but I can't think of a better way. I wish the accordion didn't have so much padding built into it. 🀷

Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰

@petertgiles petertgiles added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 1753c19 Oct 3, 2024
10 of 11 checks passed
@petertgiles petertgiles deleted the 11575-fix-manaer-dashboard-ui branch October 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› Manager dashboard review change requests
2 participants